Add Broadcast message support to ShardedDaemonProcess#7451
Merged
Aaronontheweb merged 1 commit intoJan 9, 2025
Merged
Conversation
Arkatufus
commented
Jan 9, 2025
Comment on lines
+115
to
+122
| if (message is Broadcast broadcast) | ||
| { | ||
| var unwrapped = broadcast.Message; | ||
| foreach (var entityId in _entityIds) | ||
| { | ||
| _shardingRef.Forward(new ShardingEnvelope(entityId, unwrapped)); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Special case, when message is wrapped inside the Broadcast envelope, send the payload to all worker entities.
Aaronontheweb
approved these changes
Jan 9, 2025
Member
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
LGTM - I marked this as an "API change" but really it's a behavioral change. Either way, I think it's a nice addition to the ShardedDaemonProcess.
Aaronontheweb
pushed a commit
that referenced
this pull request
Jan 10, 2025
This was referenced Oct 7, 2025
This was referenced Oct 7, 2025
This was referenced Nov 6, 2025
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7450
Changes
Add
Broadcastmessage supportChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):