Skip to content

Fix SaveSnapshot timestamp metadata #7334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 1 commit into from
Sep 4, 2024
Merged

Fix SaveSnapshot timestamp metadata #7334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/core/Akka.Persistence/Snapshot/SnapshotStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,15 @@ private bool ReceiveSnapshotStore(object message)
}
else if (message is SaveSnapshot saveSnapshot)
{
var metadata = new SnapshotMetadata(saveSnapshot.Metadata.PersistenceId, saveSnapshot.Metadata.SequenceNr, DateTime.UtcNow);
var metadata = new SnapshotMetadata(saveSnapshot.Metadata.PersistenceId, saveSnapshot.Metadata.SequenceNr, saveSnapshot.Metadata.Timestamp == DateTime.MinValue ? DateTime.UtcNow : saveSnapshot.Metadata.Timestamp);
Comment thread
Aaronontheweb marked this conversation as resolved.

_breaker.WithCircuitBreaker(() => SaveAsync(metadata, saveSnapshot.Snapshot))
.ContinueWith(t => (!t.IsFaulted && !t.IsCanceled)
? new SaveSnapshotSuccess(metadata) as ISnapshotResponse
: new SaveSnapshotFailure(saveSnapshot.Metadata,
t.IsFaulted
? TryUnwrapException(t.Exception)
: new OperationCanceledException("SaveAsync canceled, possibly due to timing out.")),
: new OperationCanceledException("SaveAsync canceled, possibly due to timing out.", TryUnwrapException(t.Exception))),
_continuationOptions)
.PipeTo(self, senderPersistentActor);
}
Expand Down Expand Up @@ -196,8 +196,7 @@ private bool ReceiveSnapshotStore(object message)

private Exception TryUnwrapException(Exception e)
{
var aggregateException = e as AggregateException;
if (aggregateException != null)
if (e is AggregateException aggregateException)
Comment thread
Aaronontheweb marked this conversation as resolved.
{
aggregateException = aggregateException.Flatten();
if (aggregateException.InnerExceptions.Count == 1)
Expand Down