Skip to content

Akka.Cluster: added sanity check for Member.AgeComparer #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 1 commit into from
Jul 22, 2024
Merged

Akka.Cluster: added sanity check for Member.AgeComparer #7291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/core/Akka.Cluster.Tests/MemberOrderingSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,23 @@ public void LeaderOrdering_must_order_members_with_status_joining_exiting_down_l
var shuffled = expected.Shuffle().ToImmutableList();
shuffled.Sort(Member.LeaderStatusOrdering).Should().BeEquivalentTo(expected);
}

[Fact]
public void MemberAgeOrdering_must_order_members_by_ascending_UpNumber()
{
var address = new Address("akka.tcp", "sys1", "host1", 5000);
var m1 = TestMember.Create(address, MemberStatus.Up, ImmutableHashSet<string>.Empty, upNumber: 1);
var m2 = TestMember.Create(address.WithPort(7000), MemberStatus.Up, ImmutableHashSet<string>.Empty, upNumber: 2);
var m3 = TestMember.Create(address.WithPort(3000), MemberStatus.Up, ImmutableHashSet<string>.Empty, upNumber: 3);
var m4 = TestMember.Create(address.WithPort(6000), MemberStatus.Up, ImmutableHashSet<string>.Empty, upNumber: 4);
var m5 = TestMember.Create(address.WithPort(2000), MemberStatus.Up, ImmutableHashSet<string>.Empty, upNumber: 5);

// shuffle the list so the members aren't initially sorted by order
var members = new List<Member>(){ m1, m2, m3, m4, m5 }.Shuffle();
var sortedMembers = ImmutableSortedSet<Member>.Empty.WithComparer(Member.AgeOrdering).Union(members);
sortedMembers.Should().BeEquivalentTo(new List<Member> { m1, m2, m3, m4, m5 });
m1.IsOlderThan(m5).Should().BeTrue();
}
}
}