Skip to content

Fix DbCommand.CommandTimeout - #6175

Merged
Aaronontheweb merged 1 commit into
akkadotnet:devfrom
Arkatufus:Fix_#6174_BatchingSqlJournal_command_timeout
Oct 14, 2022
Merged

Aaronontheweb merged 1 commit into
akkadotnet:devfrom
Arkatufus:Fix_#6174_BatchingSqlJournal_command_timeout

Conversation

@Arkatufus

Copy link
Copy Markdown
Contributor

Fixes #6174

using (var command = (TCommand)connection.CreateCommand())
{
command.CommandTimeout = (int)Setup.ConnectionTimeout.TotalMilliseconds;
command.CommandTimeout = (int)Setup.ConnectionTimeout.TotalSeconds;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DbCommand.CommandTimeout is expressed in seconds, not milliseconds.

@Aaronontheweb
Aaronontheweb merged commit 695fada into akkadotnet:dev Oct 14, 2022
@Aaronontheweb

Copy link
Copy Markdown
Member

Needs to be backported to v1.4

Arkatufus added a commit to Arkatufus/akka.net that referenced this pull request Oct 14, 2022
Aaronontheweb pushed a commit that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connection timeout is not respected for event journal commands when using BatchingSqlJournal

2 participants