Repository navigation
add HashCodeMEssageExtractor Factory method - #6173
Merged
Merged
Conversation
JonnyII
changed the title
| /// </summary> | ||
| public abstract class HashCodeMessageExtractor : IMessageExtractor | ||
| { | ||
| private class Implementation : HashCodeMessageExtractor |
Member
There was a problem hiding this comment.
LGTM - I think this is convenient.
Aaronontheweb
approved these changes
Oct 14, 2022
Aaronontheweb
left a comment
Aaronontheweb
left a comment
Member
There was a problem hiding this comment.
LGTM - @Arkatufus we'll need to backport this to v1.4.44
Aaronontheweb
enabled auto-merge (squash)
October 14, 2022 15:20
Member
|
Looks like AzDo is having some issues downloading manifests for Windows agents - seeing some other PRs failing from that right now also. |
Aaronontheweb
disabled auto-merge
October 14, 2022 17:20
Member
|
Unrelated spec failure. |
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
Oct 14, 2022
* feat: add add HashCodeMEssageExtractor Factory method * test: verified change of previous commit * test: verified missing api changes Co-authored-by: Aaron Stannard <aaron@petabridge.com> Co-authored-by: Gregorius Soedharmo <arkatufus@yahoo.com>
Aaronontheweb
added a commit
that referenced
this pull request
Oct 14, 2022
* add HashCodeMEssageExtractor Factory method (#6173) * feat: add add HashCodeMEssageExtractor Factory method * test: verified change of previous commit * test: verified missing api changes Co-authored-by: Aaron Stannard <aaron@petabridge.com> Co-authored-by: Gregorius Soedharmo <arkatufus@yahoo.com> * Update API Verify list Co-authored-by: JonnyII <102029509+JonnyII@users.noreply.github.com> Co-authored-by: Aaron Stannard <aaron@petabridge.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes
Please provide a brief description of the changes here.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
Include data from after this change here.