Repository navigation
Add Cluster.Sharding ActorInitializationException spec - #5999
Merged
Aaronontheweb merged 3 commits intoJun 14, 2022
Merged
Aaronontheweb merged 3 commits into
Aaronontheweb merged 3 commits into
Conversation
… exceptions thrown from entity constructor and PreStart method
Arkatufus
commented
Jun 14, 2022
|
|
||
| var settings = ClusterShardingSettings.Create(Sys); | ||
| var tuning = settings.TuningParameters; | ||
| settings = settings.WithTuningParameters(new TuningParameters |
Contributor
Author
There was a problem hiding this comment.
This is a very bad coding experience. We need to at least add a Copy() method to TuningParameter class so no one should be forced to write this. Or use the record feature in .NET 5.0
Member
There was a problem hiding this comment.
agree. Can't go record until we drop .NET Standard 2.0 support, which isn't slated until 2.0.
Aaronontheweb
approved these changes
Jun 14, 2022
Aaronontheweb
left a comment
Aaronontheweb
left a comment
Member
There was a problem hiding this comment.
LGTM - port this to 1.5 also.
Member
|
Looks like this test fails under some conditions. |
Aaronontheweb
self-requested a review
June 14, 2022 17:09
Aaronontheweb
requested changes
Jun 14, 2022
Aaronontheweb
left a comment
Aaronontheweb
left a comment
Member
There was a problem hiding this comment.
Have an intermittent test failure.
Aaronontheweb
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add spec to make sure that Cluster.Sharding can survive any transient exceptions thrown from entity constructor and PreStart method