replaced cref="..." with cref="@...`

[eaba]

Part fix for #5542

@Aaronontheweb

This log shows warnings about Invalid cref value "!:xxxxxxx" found in triple-slash-comments.... which I have not been able to reproduce locally. Locally the warnings are down to 201 with majority of the WARNINGS being Could not resolve base documentation for.

I found this comment interesting dotnet/docfx#5112 (comment) @Arkatufus

[Aaronontheweb]

Need to remove this

[Aaronontheweb]

i.e. the entire file needs to be deleted

[Aaronontheweb]

I just found out you can disable these CREF warnings via #pragma warning disable CS0419 // Ambiguous reference in cref attribute while reviewing #4629 - that might be helpful in some instances where the cref is actually useful but can't be resolved.

[Aaronontheweb]

@eaba that comment is interesting - maybe we need to modify the DocFx build step in FAKE to do buildRelease first THEN compile the documentation? Give that a try?

[eaba]

@eaba that comment is interesting - maybe we need to modify the DocFx build step in FAKE to do buildRelease first THEN compile the documentation? Give that a try?

I think @Arkatufus should look into how #5542 uses docfx. Because on my machine, the warning are not there!

Right now the only way forward is to work with the warnings I got from running build.cmd docfx locally.

[Aaronontheweb]

@eaba that comment is interesting - maybe we need to modify the DocFx build step in FAKE to do buildRelease first THEN compile the documentation? Give that a try?

I think @Arkatufus should look into how #5542 uses docfx. Because on my machine, the warning are not there!

Right now the only way forward is to work with the warnings I got from running build.cmd docfx locally.

You can look at the PR and see what he's doing there

[Aaronontheweb]

No longer needed as a result of DocFx build changes per @eaba