Skip to content

Wait for radio silence - #5578

Merged
Aaronontheweb merged 6 commits into
akkadotnet:devfrom
brah-mcdude:WaitForRadioSilence
Feb 10, 2022
Merged

Aaronontheweb merged 6 commits into
akkadotnet:devfrom
brah-mcdude:WaitForRadioSilence

Conversation

@brah-mcdude

Copy link
Copy Markdown
Contributor

Fixes:
Nothing is fixed in this PR.

Changes:

  1. I added a new API method: WaitForRadioSilenceAsync
  2. I added a bunch of tests for this new method

A brief description of the changes:
I have been using my own WaitForRadioSilenceAsync for a while now.
And I find it very useful. So I thought to contribute it to the community.
As its name suggests, it waits for radio silence.
"radio silence": A period of time during which no messages are encountered by a probe.

Is it a significant change:
No.

Comment thread src/core/Akka.TestKit/TestKitBase_Receive.cs Outdated
@brah-mcdude

Copy link
Copy Markdown
Contributor Author

Fixed issue:
WaitForRadioSilenceAsync should use ReceiveOne and not ReceiveWhile #5585

@Arkatufus Arkatufus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb
Aaronontheweb merged commit 7f402d9 into akkadotnet:dev Feb 10, 2022
@brah-mcdude
brah-mcdude deleted the WaitForRadioSilence branch February 10, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants