Skip to content

Updated configuration section with sample code - #5567

Merged
Aaronontheweb merged 2 commits into
akkadotnet:devfrom
eaba:show_how_to_pass_custom_config_to_akka_testkit
Feb 4, 2022
Merged

Aaronontheweb merged 2 commits into
akkadotnet:devfrom
eaba:show_how_to_pass_custom_config_to_akka_testkit

Conversation

@eaba

@eaba eaba commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Fixes #5413

Changes

Replaced TODO with sample code

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the DocFx reference

// </copyright>
//-----------------------------------------------------------------------

#region ClusterSingletonConfigSpec

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to include the entire test here - only need the constructor.

Use the //<{name}> syntax to target a small area of code, rather than a #region

See: https://getakka.net/community/contributing/documentation-guidelines.html#code-samples-must-use-code-references

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb
Aaronontheweb merged commit 75896cb into akkadotnet:dev Feb 4, 2022
@Aaronontheweb Aaronontheweb added docs akka-testkit Akka.NET Testkit issues labels Feb 4, 2022
@eaba
eaba deleted the show_how_to_pass_custom_config_to_akka_testkit branch February 4, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

akka-testkit Akka.NET Testkit issues docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: need to show how to pass custom configuration to Akka.TestKit

2 participants