Repository navigation
Fixing Racy ClusterLogVerboseEnabledSpec - #5548
Merged
Aaronontheweb merged 4 commits intoJan 29, 2022
Merged
Conversation
* Converted test to `async/await`
eaba
commented
Jan 28, 2022
| await EventFilter | ||
| .Info(contains: expected) | ||
| .ExpectOne(() => _cluster.Join(_selfAddress)); | ||
| .ExpectOneAsync(TimeSpan.FromMinutes(1), () => _cluster.Join(_selfAddress)); |
Contributor
Author
There was a problem hiding this comment.
The default timeout was 3s....bumped this up to see how that goes! The test failed at times due to timeout.
* Created `DownAsync` of `Down`
Member
|
What's the error message this test usually fails with? |
Contributor
Author
Timeout (00:00:03) while waiting for messages. Only received 0/1 messages that matched filter [Info when Message contains " - event MemberUp"]
Expected: True
Actual: Falseat Akka.TestKit.Xunit2.XunitAssertions.Fail(String format, Object[] args) in D:\a\1\s\src\contrib\testkits\Akka.TestKit.Xunit2\XunitAssertions.cs:line 26
at Akka.TestKit.Internal.InternalEventFilterApplier.Intercept[T](Func`1 func, ActorSystem system, Nullable`1 timeout, Nullable`1 expectedOccurrences, MatchedEventHandler matchedEventHandler) in D:\a\1\s\src\core\Akka.TestKit\EventFilter\Internal\EventFilterApplier.cs:line 309
at Akka.TestKit.Internal.InternalEventFilterApplier.InternalExpect(Action action, ActorSystem actorSystem, Int32 expectedCount, Nullable`1 timeout) in D:\a\1\s\src\core\Akka.TestKit\EventFilter\Internal\EventFilterApplier.cs:line 451
at Akka.TestKit.Internal.InternalEventFilterApplier.ExpectOne(Action action) in D:\a\1\s\src\core\Akka.TestKit\EventFilter\Internal\EventFilterApplier.cs:line 46
at Akka.Cluster.Tests.ClusterLogSpec.<>c__DisplayClass9_0.<Join>b__0() in D:\a\1\s\src\core\Akka.Cluster.Tests\ClusterLogSpec.cs:line 65
at Akka.TestKit.TestKitBase.<>c__DisplayClass158_0.<Within>b__0() in D:\a\1\s\src\core\Akka.TestKit\TestKitBase_Within.cs:line 57
at Akka.TestKit.TestKitBase.Within[T](TimeSpan min, TimeSpan max, Func`1 function, String hint, Nullable`1 epsilonValue) in D:\a\1\s\src\core\Akka.TestKit\TestKitBase_Within.cs:line 134
at Akka.TestKit.TestKitBase.Within(TimeSpan min, TimeSpan max, Action action, String hint, Nullable`1 epsilonValue) in D:\a\1\s\src\core\Akka.TestKit\TestKitBase_Within.cs:line 57
at Akka.TestKit.TestKitBase.Within(TimeSpan max, Action action, Nullable`1 epsilonValue) in D:\a\1\s\src\core\Akka.TestKit\TestKitBase_Within.cs:line 32
at Akka.Cluster.Tests.ClusterLogSpec.Join(String expected) in D:\a\1\s\src\core\Akka.Cluster.Tests\ClusterLogSpec.cs:line 63
at Akka.Cluster.Tests.ClusterLogVerboseEnabledSpec.A_cluster_must_log_verbose_cluster_events_when_log_info_verbose_is_on() in D:\a\1\s\src\core\Akka.Cluster.Tests\ClusterLogSpec.cs:line 131 |
Member
|
LGTM |
Member
|
This spec is still failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TimeOutto 1 mins from default 3sasync/awaitJoinAsyncandDownAsyncChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):