Repository navigation
harden Bugfix4360Spec - #5256
Merged
Merged
Conversation
The `AwaitAssert` is actually what made this spec racy
Aaronontheweb
added
tests
akka-persistence-sql-common
Aaronontheweb
enabled auto-merge (squash)
September 6, 2021 16:59
Aaronontheweb
commented
Sep 6, 2021
| ExpectTerminated(recoveryActor); | ||
|
|
||
| // recreate the actor and recover | ||
| var recoveryActor2 = Sys.ActorOf(Props.Create(() => new RecoverActor(TestActor)), recoveryActor.Path.Name); |
Member
Author
There was a problem hiding this comment.
Once the Terminated is received, this actor should be safe to recreate again right away.
If it's not - we should do a "double-tap" and get a second ExpectTerminated instead of an AwaitAssert in this case.
Aaronontheweb
commented
Sep 6, 2021
| var r2 = ExpectMsg<IEnumerable<string>>(TimeSpan.FromMilliseconds(100)); | ||
| r2.Should().Contain(new[] { "foo", "bar" }); | ||
| }, interval:TimeSpan.FromMilliseconds(150)); | ||
| var r2 = ExpectMsg<IEnumerable<string>>(); |
Member
Author
There was a problem hiding this comment.
Use a longer timeout instead of AwaitAssert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AwaitAssertis actually what made this spec racy