Skip to content

Improve status messages - #5226

Merged
Aaronontheweb merged 8 commits into
akkadotnet:devfrom
Zetanova:improve-status-messages
Sep 8, 2021
Merged

Aaronontheweb merged 8 commits into
akkadotnet:devfrom
Zetanova:improve-status-messages

Conversation

@Zetanova

Copy link
Copy Markdown
Contributor

Akka.Actor.Failure and Akka.Actor.Failures are unused and got obsoleted.

Akka.Actor.Status.Success and Akka.Actor.Status.Failure got sealed to improve pattern matching perf.
Failure got a new Field 'State' that the receiver can send the command or a correlation-id to the sender back.

@Zetanova

Copy link
Copy Markdown
Contributor Author

One question require answering.
In the whole project following is used:
new Status.Success(null)
new Status.Success(Done.Instance)
new Status.Success(NotUsed.Instance)

I opt for null and added
public static readonly Success Instance = new Success(null);

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some questions on whether or not this will impact our Akka.Persistence.Sql plugins

{
protected Status() { }
public class Failure : Akka.Actor.Status
public sealed class Failure : Akka.Actor.Status

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb modified the milestones: 1.4.24, 1.4.25 Sep 1, 2021
@Aaronontheweb
Aaronontheweb enabled auto-merge (squash) September 1, 2021 18:08
@Aaronontheweb
Aaronontheweb enabled auto-merge (squash) September 6, 2021 15:52
@Aaronontheweb
Aaronontheweb merged commit 024c684 into akkadotnet:dev Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants