=act Fix dns query overriding in dnsClient. #31912
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leviramsey
reviewed
Apr 16, 2023
| case (s, _) => | ||
| s ! Failure(new RuntimeException("Send failed to nameserver")) | ||
| inflightRequests -= msg.id | ||
| unstashQuestion(msg.id) |
Contributor
There was a problem hiding this comment.
Could just be unstashAll... the questions that still collide will still collide and get re-stashed.
Contributor
|
Sorted by #31906 |
Contributor
Author
|
i think this cover different part. but feel free. |
Contributor
|
Ah, sorry, yes, this is not the async dns, but the "regular" one. |
Contributor
Author
|
If this is valid I may update this pr during the holiday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #31905
If there are multi queries issued with the same id, the current DNS client may reply the result to the wrong target.