Skip to content

Quieter logging for ShardCoordinator initialization #30488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patriknw merged 2 commits into from
Aug 18, 2021
Merged

Quieter logging for ShardCoordinator initialization #30488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b49061
Quieter logging for ShardCoordinator initialization
raboof Aug 5, 2021
7dd89be
Log the first retry on 'info'
raboof Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ShardCoordinator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,6 +1432,7 @@ private[akka] class DDataShardCoordinator(

private var terminating = false
private var getShardHomeRequests: Set[(ActorRef, GetShardHome)] = Set.empty
private var initialStateRetries = 0

private val rememberEntitiesStore =
rememberEntitiesStoreProvider.map { provider =>
Expand Down Expand Up @@ -1468,10 +1469,16 @@ private[akka] class DDataShardCoordinator(
onInitialState(existingState, rememberedShards)

case GetFailure(CoordinatorStateKey, _) =>
log.error(
"{}: The ShardCoordinator was unable to get an initial state within 'waiting-for-state-timeout': {} millis (retrying). Has ClusterSharding been started on all nodes?",
typeName,
stateReadConsistency.timeout.toMillis)
initialStateRetries += 1
val template =
"{}: The ShardCoordinator was unable to get an initial state within 'waiting-for-state-timeout': {} millis (retrying). Has ClusterSharding been started on all nodes?"
if (initialStateRetries == 1)
log.info(template, typeName, stateReadConsistency.timeout.toMillis)
else if (initialStateRetries < 5)
log.warning(template, typeName, stateReadConsistency.timeout.toMillis)
else
log.error(template, typeName, stateReadConsistency.timeout.toMillis)

// repeat until GetSuccess
getCoordinatorState()

Expand Down