Repository navigation
inmem journal must not reset highestSequenceNr after journal cleanup, #27994 - #27995
Merged
Merged
Conversation
patriknw
commented
Oct 14, 2019
patriknw
commented
Contributor
- add tck test (failed for exactly this)
- keep track of highest
…27994 * add tck test (failed for exactly this) * keep track of highest
patriknw
added
the
2 - pick next
Contributor
Author
|
Follow up from #27496 |
akka-ci
added
validating
|
Test PASSed. |
helena
reviewed
Oct 15, 2019
| // persistenceId -> persistent message | ||
| var messages = Map.empty[String, Vector[PersistentRepr]] | ||
| // persistenceId -> highest used sequence number | ||
| private var highestSequenceNumbers = Map.empty[String, Long] |
Contributor
There was a problem hiding this comment.
Makes me wonder if we'd need a faster data structure or if this isn't quite on the hot path then no.
Contributor
Author
There was a problem hiding this comment.
inmem journal is only intended for testing so shouldn't be a problem
johanandren
approved these changes
Oct 15, 2019
Contributor
Author
|
Refs #27994 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.