Repository navigation
Mailbox selection for Akka Typed actors - #27183
Merged
johanandren merged 8 commits intoJul 16, 2019
Merged
johanandren merged 8 commits into
johanandren merged 8 commits into
Conversation
akka-ci
added
validating
|
Test FAILed. |
johanandren
commented
Jun 19, 2019
| // mailbox configurators for the same size | ||
| val capacity = id.split(':')(1).toInt | ||
| new BoundedMailbox(capacity, Duration.Zero) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Not exactly my proudest moment encoding this in strings but allowed for minimal changes in untyped + caching of the configurator.
Contributor
There was a problem hiding this comment.
The caching argument is good. I think it's ok.
akka-ci
added
validating
|
Test FAILed. |
helena
reviewed
Jun 19, 2019
helena
reviewed
Jun 19, 2019
helena
reviewed
Jun 19, 2019
patriknw
reviewed
Jun 19, 2019
| // mailbox configurators for the same size | ||
| val capacity = id.split(':')(1).toInt | ||
| new BoundedMailbox(capacity, Duration.Zero) | ||
|
|
Contributor
There was a problem hiding this comment.
The caching argument is good. I think it's ok.
akka-ci
added
validating
|
Test FAILed. |
Co-Authored-By: Helena Edelson <helena@users.noreply.github.com>
johanandren
force-pushed
the
wip-27124-mailbox-selector-props-typed-johanandren
branch
from
July 10, 2019 13:50
ea46524 to
f6d24db
Compare
akka-ci
added
validating
|
Test PASSed. |
patriknw
approved these changes
Jul 11, 2019
patriknw
left a comment
patriknw
left a comment
Contributor
There was a problem hiding this comment.
LGTM, with some minor nits
akka-ci
added
validating
|
Test PASSed. |
jrudolph
approved these changes
Jul 16, 2019
| /** | ||
| * Scala API: The default mailbox is unbounded and backed by a [[java.util.concurrent.ConcurrentLinkedQueue]] | ||
| */ | ||
| def default(): MailboxSelector = DefaultMailboxSelector.empty |
Contributor
There was a problem hiding this comment.
Does it need parentheses for the Scala version?
Contributor
Author
There was a problem hiding this comment.
Hmm, maybe not, on the fence, on one hand it is a constant/no side effect on the other hand maybe that fact is an implementation detail. This is aligned with the dispatcher selector though.
| @@ -202,8 +206,14 @@ private[akka] class Mailboxes( | |||
| // It doesn't matter if we create a mailbox type configurator that isn't used due to concurrent lookup. | |||
| val newConfigurator = id match { | |||
| // TODO RK remove these two for Akka 2.3 | |||
Contributor
There was a problem hiding this comment.
Woops, that TODO slipped it seems...
| case _ if id.startsWith(BoundedCapacityPrefix) => | ||
| // hack to allow programmatic set of capacity through props in akka-typed but still share | ||
| // mailbox configurators for the same size | ||
| val capacity = id.split(':')(1).toInt |
Contributor
There was a problem hiding this comment.
I guess it's ok for us if that fails with a cryptic exception in case we or someone else doesn't follow the format.
Contributor
Author
There was a problem hiding this comment.
Yeah, it's not public API in any way
…ter/PropsAdapter.scala Co-Authored-By: Johannes Rudolph <johannes.rudolph@gmail.com>
akka-ci
added
validating
|
Test PASSed. |
johanandren
deleted the
wip-27124-mailbox-selector-props-typed-johanandren
branch
July 16, 2019 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow for selection of mailbox type in Akka Typed through
PropsReferences
Fixes #27124
Changes
New API
MailboxSelector, support inPropsAdapter, hack inakka-actorto allow for programmatic passing of bounded mailbox capacity from typed.