Elides the need to allocate an AkkaForkJoinTask per Mailbox-submission to... #16150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+act Add japi.Pair and japi.Predicate for streams
=act Add @serialversionuid to japi.Pair
=doc #15234 add new google analytics tracker
=pro #15116 Update Typesafe Config to 1.2.1
=act Add `putByteArrayUnsafe` optimization to `ByteStringBuilder`
…PI-backport-patriknw +con #15157 Changed ClusterSharding.start to return the shardRegion (for validation)
…ting for Register
=act #15265 Make TcpConnection handle Suspend/ResumeReading while waiting for Register
…s-test-2.3-ban =pro #15290 Make validatePullRequest run all tests
…problem-ban =per #15280 Make snapshot header length field deserialize correctly
+pro backported github-tagging (jenkins utility) to 2.3 branch
=act #15265 Enable OP_READ interest for pullMode early ResumeReading
…-more-robust-ban =per #15212 Avoid half written snapshots in LocalSnapshotStore
Port minor typeannotation fix
+proj porting akka-bench-jmh to release-2.3
…-check-ban =per #15131 Make LocalSnapshotStore fail if it can't create target directory
=doc #16000 fix tck-experimental version
…ktoso =doc fix unclosed quotes in docs
* Updated CSS Styles, new logos (SVG format), New header/nav design. General colors overrides, small but safe HTML changes, new favicon. * Updated GA snippet with addition domain, added Marketo snippet * Made fonts consistent, styled note and warning in TS/Akka colors
(Validation back port) =doc New styling and logos for the documentation
=doc #16134 read file as binary stream, because StreamReader expects binary (backport)
=doc Link to CONTRIBUTING.md and remove obsolete dev guidelines
viktorklang
changed the title
Contributor
Author
There was a problem hiding this comment.
ForkJoinPool has an execute overload that takes a ForkJoinTask, we use that instead of execute(runnable) to elide some instanceof checks.
Contributor
|
Very neat! However this PR is against a wrong branch. |
Contributor
Author
|
I can retarget against 2.3 :-) |
Contributor
|
That would be shiny, capt'n! :) |
akka-ci
added
tested
|
Test PASSed. |
… to registerForExecution by having Mailbox extend ForkJoinTask and using the fact that `ForkJoinTask.exec` when returning `false` does not set completion on the task, so it is free to be resubmitted to the `ForkJoinPool` without reinitialization.
viktorklang
force-pushed
the
wip-fjp-optimize-√
branch
from
d35c596 to
bcc0470
Compare
akka-ci
added
validating
Contributor
Author
|
Reopening against release-2.3 |
Contributor
Author
|
See: #16152 |
|
Test FAILed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... registerForExecution
by having Mailbox extend ForkJoinTask and using the fact that
ForkJoinTask.execwhen returningfalsedoes not set completion on the task, so it is free to be resubmitted to theForkJoinPoolwithout reinitialization.