Skip to content

+str #15081 Rate detached ops#15244

Merged
drewhk merged 1 commit intoakka:release-2.3-devfrom
drewhk:wip-15081-rate-detach-ops-drewhk
May 23, 2014
Merged

+str #15081 Rate detached ops#15244
drewhk merged 1 commit intoakka:release-2.3-devfrom
drewhk:wip-15081-rate-detach-ops-drewhk

Conversation

@drewhk
Copy link
Contributor

@drewhk drewhk commented May 20, 2014

Implemented:

  • conflate
  • expand
  • buffer with policies (droptail, drophead, dropbuffer, backpressure)

Duct, docs, Java API TBD. Otherwise ready for review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not in akka.stream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally the package

@drewhk drewhk added the tested label May 20, 2014
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to fill a new array with nulls, Array.ofDim should be fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger!

@drewhk
Copy link
Contributor Author

drewhk commented May 22, 2014

Fixed comments, added Java API, Duct, rebased and squashed

@akka-ci
Copy link

akka-ci commented May 22, 2014

Pull request validation: FAILED.
Refer to this link for build results: https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/54/

@akka-ci
Copy link

akka-ci commented May 22, 2014

Pull request validation: FAILED.
Refer to this link for build results: https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/55/

@drewhk
Copy link
Contributor Author

drewhk commented May 23, 2014

PLS BUILD

@drewhk drewhk added validating and removed tested labels May 23, 2014
@akka-ci
Copy link

akka-ci commented May 23, 2014

Pull request validation: FAILED 👎
Refer to this link for build results: https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/63/

@drewhk
Copy link
Contributor Author

drewhk commented May 23, 2014

PullReadingSpec failed again.

@drewhk
Copy link
Contributor Author

drewhk commented May 23, 2014

Fixes #15081

@bantonsson
Copy link
Contributor

Well, just review the fix then #15277 😉

drewhk pushed a commit that referenced this pull request May 23, 2014
@drewhk drewhk merged commit 5da90e3 into akka:release-2.3-dev May 23, 2014
@drewhk drewhk deleted the wip-15081-rate-detach-ops-drewhk branch May 23, 2014 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-attention Indicates a PR validation failure (set by CI infrastructure)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants