docs: fix lua codes, consistent nerdfonts symbols, formatting #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It tried to compare bool with bool which is invalid lua.
Previously a new highlight was created and cached for each index. For example when the result table only has a warning, an orange color highlight will be created and cached for index 1. Then the user fixes the warning but generates an error with index 1, the orange color will be reused from the cache rather than creating a highlight for the associated red color.
|
Hi @gepbird, These appear to be a lot of stylistic changes mixed in with some more important fixes. Can we just address the crucial fixes first in a minimal PR just aimed at those then discuss any style changes as a followup. In general a lot of the attempts to add booleans and things like that are actually contrary to my intentions. The reason I added them like that was actually to specifically discourage copy-pasting which ends up being a huge cause of issues for me since if the code is clearly not copy-pastable people tend to add things in themselves rather than copy a huge blob then complain it doesn't work as they expect |
|
Sure, I'll break these changes up to multiple PRs. |
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last formatting commit 7eb3326 has a much bigger diff than the other commits, please review commit-by-commit rather than all commits at the same time to make it easier for yourself :)
Let me know if you prefer another style for lua code in docs, I mostly followed the project's
stylua.tomlwith a few exceptions: