fix: replace tbl_flatten to flatten():totable() #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pablobfonseca
commented
May 20, 2024
pablobfonseca
commented
- support nvim < 0.10
- support nvim < 0.10
akinsho
reviewed
May 21, 2024
lua/bufferline/utils/init.lua
Outdated
| @@ -275,4 +275,8 @@ else | |||
| M.is_list = vim.tbl_isarray or vim.tbl_islist | |||
| end | |||
|
|
|||
| function M.tbl_flatten(t) | |||
| return vim.fn.has("nvim-0.10") == 1 and vim.iter(t):flatten(math.huge):totable() or vim.tbl_flatten(t) | |||
There was a problem hiding this comment.
Could you pull this check out to the files top level as it's a static value really to prevent having to recalculate this every time this function is called
There was a problem hiding this comment.
@akinsho done! let me know if that makes sense
There was a problem hiding this comment.
@akinsho I changed to check for the version 0.11 for flatten like it's being done on the telescope plugin:
https://github.com/nvim-telescope/telescope.nvim/blob/4aed63995a69e343b068c7469491a8d1592c339f/plugin/telescope.lua#L121
sstallion
pushed a commit
to sstallion/bufferline.nvim
that referenced
this pull request
Jul 3, 2024
* fix: replace tbl_flatten to flatten():totable() - support nvim < 0.10 * fix: extract nvim version check to a variable * fix: check if is nvim 0.11 for flatten()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.