refactor(tabs): tab is modified if any child buffer is modified #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwblokzijl
changed the title
akinsho
reviewed
Sep 17, 2022
akinsho
requested changes
Sep 17, 2022
There was a problem hiding this comment.
This LGTM other than one comment I left. It's worth noting that whilst this seems fine to me, I can't predict whether some other tabs user will turn around and complain that they prefer the alternate way of working 🤷🏿♂️. Might call on you to defend this but definitely would rather only one mechanism here and this seems sensible
|
Sounds good. I cannot personally think of a workflow where this feature would be unwanted, but if one comes along I'll be happy to join the discussion. |
akinsho
approved these changes
Sep 18, 2022
akinsho
changed the title
akinsho
added a commit
that referenced
this pull request
Sep 19, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a buffer is modified within a tab, the tab is only marked as modified if that buffer is in focus. This PR marks the tab as modified if any of the buffers in the tab are modified.