-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tabs): tab is modified if any child buffer is modified #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM other than one comment I left. It's worth noting that whilst this seems fine to me, I can't predict whether some other tabs user will turn around and complain that they prefer the alternate way of working 🤷🏿♂️. Might call on you to defend this but definitely would rather only one mechanism here and this seems sensible
Sounds good. I cannot personally think of a workflow where this feature would be unwanted, but if one comes along I'll be happy to join the discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 thanks for tweaking it 👍🏿
If a buffer is modified within a tab, the tab is only marked as modified if that buffer is in focus. This PR marks the tab as modified if any of the buffers in the tab are modified.