Check parameter validity in Object::set_script

Fixes godotengine#46120. (cherry picked from commit 9c6c2f0)
akien-mga · Oct 30, 2023 · fe79dc9 · fe79dc9
1 parent 5464004
commit fe79dc9
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/core/object.cpp b/core/object.cpp
@@ -1004,14 +1004,16 @@ void Object::set_script(const RefPtr &p_script) {
 		return;
 	}
 
+	Ref<Script> s = p_script;
+	ERR_FAIL_COND_MSG(s.is_null() && !p_script.is_null(), "Invalid parameter, it should be a reference to a valid script (or null).");
+
+	script = p_script;
+
 	if (script_instance) {
 		memdelete(script_instance);
 		script_instance = nullptr;
 	}
 
-	script = p_script;
-	Ref<Script> s(script);
-
 	if (!s.is_null()) {
 		if (s->can_instance()) {
 			OBJ_DEBUG_LOCK