Silence StyleCop warnings #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akgulebubekir your call whether to merge this, or follow another approach. |
symbiogenesis
force-pushed
the
silence-warnings
branch
2 times, most recently
from
ddc51da
to
54a59dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently turned on lots of warnings to help ensure readability, code quality, and consistency. I fixed the uncontroversial warnings.
In this PR, the controversial warnings from before I am silencing, which should preserve most of the original stylistic feeling.
These are: SA1101, SA1124, and SA1309
The general concept behind SA1101 and SA1309, as described, is to make it explicit that you are calling a method of a particular instance, and that you are covertly passing "this" to non-static methods. It also allows better IntelliSense.
SA1124 recommends not using regions and provides an explanation for why. Regardless, the other element ordering rules which are being followed will help ensure consistent member ordering and readability, with or without regions.