PH-430: Store database install time #18651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmleroux
force-pushed
the
PH-430-install-time
branch
from
24ef289 to
3cd39c4
Compare
ghoussard
approved these changes
Dec 13, 2022
upgrades/schema/Version_7_0_20221212160000_add_database_install_time.php
Outdated
Show resolved
Hide resolved
nmarniesse
approved these changes
Dec 13, 2022
src/Akeneo/Platform/Bundle/InstallerBundle/Persistence/Query/InstallTimeQuery.php
Outdated
Show resolved
Hide resolved
jmleroux
force-pushed
the
PH-430-install-time
branch
from
ac1e95c to
77d1aa4
Compare
ahocquard
reviewed
Dec 13, 2022
| * @copyright 2022 Akeneo SAS (http://www.akeneo.com) | ||
| * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0) | ||
| */ | ||
| final class InstallDataQuery |
There was a problem hiding this comment.
It's not a SQL query, but not from the application point of view (command and query generally).
PersistInstallTime in a different namespace Persistence/Sql?
| { | ||
| } | ||
|
|
||
| public function setInstallTime(): void |
There was a problem hiding this comment.
withDatetime and I would delegate the responsibility of specifying the datetime to the caller for testability (because it's missing a test and this insert is important).
| @@ -184,6 +174,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| ); | |||
| } | |||
|
|
|||
| $this->installTimeQuery->setInstallTime(); | |||
There was a problem hiding this comment.
will you create a dedicated service for installation later on?
There was a problem hiding this comment.
Maybe. Probably. :)
jmleroux
force-pushed
the
PH-430-install-time
branch
from
49971b3 to
1e95a7d
Compare
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 30, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
pim_configurationentry to store some installation data. Currently only the time of installation.This data will be then used to check if a PIM is installed instead of the current test which only test for
oro_usertable existence. Because this table can exists even if there were issues in the install process.The date is set only at the end of the full database installation and is then more strict than the mere presence of a table.
I also add a migration to initialize this date for existing PIMs. I use the
oro_usertable creation date to be consistent with the current test.