GRF-599 fix blank page on categories when manipulating channels list before it is fetched #18504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanS29-akeneo
approved these changes
Nov 24, 2022
src/Akeneo/Category/front/src/feature/components/EditAttributesForm.tsx
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/front/src/feature/components/channel/ChannelSelector.tsx
Outdated
Show resolved
Hide resolved
|
The issue looks to come from this line A solution could be to fully accept that the value possibly does not exist in the list of values and the component should be resilient enough to handle it. Could you add some tests to cover this use case please? |
src/Akeneo/Category/front/src/feature/components/EditAttributesForm.tsx
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/front/src/feature/components/channel/ChannelSelector.tsx
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/front/src/feature/components/channel/ChannelSelector.tsx
Outdated
Show resolved
Hide resolved
antoinetrouve
approved these changes
Nov 25, 2022
olivierpontier
approved these changes
Nov 28, 2022
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 30, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (for Contributor and Core Developer)
When the PIM is build and launched for the 1st time, or when we delete the project's cache, the ChannelSelector component receives an empty list of channels. It try to access the "code" property of every channel of this empty list which resulted in an error and a blank page.
Now we do not display the component if the channels list is empty
Definition Of Done (for Core Developer only)