Add error propagation from child thread to main thread #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A try/except block is added in the `enqueue_updates` method to catch any exceptions during the subscription process. These exceptions are stored in a new attribute `self.error`, making them accessible in the main thread. As a result of this change, the caller should check `self.error` after each operation to handle any potential exceptions raised in the child thread.
|
Trying to solve this: #104 |
|
@brunoonovais Can you please check this. |
|
Looks ok @AscendedEntity , let's see how tests will work out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A try/except block is added in the
enqueue_updatesmethod to catch any exceptions during the subscription process. These exceptions are stored in a new attributeself.error, making them accessible in the main thread.As a result of this change, the caller should check
self.errorafter each operation to handle any potential exceptions raised in the child thread.