-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependabot for dependency upgrades #763
base: master
Are you sure you want to change the base?
Add dependabot for dependency upgrades #763
Conversation
Thanks @clintonsteiner! So does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we somehow test this before merging?
Also, a change log entry would be nice.
https://github.com/clintonsteiner/darker/actions/runs/11605270324/job/32315372582 |
#767 I was unable to make dependabot acknowledge both files and seems a pain to manage both |
@@ -60,7 +60,7 @@ color = | |||
Pygments>=2.4.0 | |||
test = | |||
# NOTE: remember to keep `constraints-oldest.txt` in sync with these | |||
black>=22.3.0 | |||
black>=24.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What, did dependabot claim there are vulnerabilities in older versions of Black?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do see a CVE security vulnerability in Black 24.3.0 though. But I couldn't find anything before 24.1.0 which would have been fixed in that version.
I guess it makes sense to drop support for Black <24.3.0, but on the other hand I wouldn't like to break users' workflows if they for any reason choose to pin to a selected Black version. And if the code they are formatting is all internal and trusted, I think that's a valid decision.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how dependabot will react to dependencies in extras – Black will be moved there in #759.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It tried to update the constraints-oldest.txt file but left the setup.cfg alone
Think we need to have dependencies defined only in one spot for dependabot
I noticed you closed #767 – did you find a work-around? I wanted to move away from But: Due to missing raw HTML support on PyPI, we still depend on |
#341