-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gen_python_files usage for black>=21.7b1.dev9 #189
Conversation
As noted by @flying-sheep, I already had a fix for this in #183. The difference is that my solution looks at |
Could you add a change log entry similar to the one in the alternative pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see a couple of comments in the review. I'm starting to think I like the inspect
approach better than looking at the Black version.
Co-authored-by: Antti Kaihola <[email protected]>
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.44%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
I think the approach here is simpler in two ways:
but ultimately it’s a matter of taste as both solutions are likely to be robust. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @flying-sheep for the improved solution!
This should fix the tests and be backwards compatible