Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

[ABO-202] Whitelist Freemint Transfer for accounts #373

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

DidacSF
Copy link
Contributor

@DidacSF DidacSF commented Nov 15, 2023

Description

See details in https://ajunanetwork.atlassian.net/browse/ABO-202

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (9744028) 75.19% compared to head (b3b5e6a) 77.55%.

Files Patch % Lines
pallets/ajuna-awesome-avatars/src/migration/v6.rs 0.00% 43 Missing ⚠️
pallets/ajuna-awesome-avatars/src/lib.rs 65.62% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #373      +/-   ##
===========================================
+ Coverage    75.19%   77.55%   +2.36%     
===========================================
  Files           36       36              
  Lines         4269     4166     -103     
===========================================
+ Hits          3210     3231      +21     
+ Misses        1059      935     -124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@darkfriend77 darkfriend77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is important to have the configuration consistently in the GlobalConfig, for the turn off and on, whitelist storage for accounts is fine

pallets/ajuna-awesome-avatars/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@darkfriend77 darkfriend77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an inconsistency here.

each config has an open flag which should open or close this function,

so if we do this properly the freemint should have it's own config, and transfer should only apply to avatars.

I know this will involve a storage migration.

* Added v6 migration
* Clippy fixes on benchmarking
@darkfriend77 darkfriend77 merged commit c154aa5 into develop Jan 8, 2024
13 checks passed
@darkfriend77 darkfriend77 deleted the AB0-202 branch January 8, 2024 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants