Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

[PLAT-803] Split AvatarVersion #310

Merged
merged 2 commits into from
Jun 19, 2023
Merged

[PLAT-803] Split AvatarVersion #310

merged 2 commits into from
Jun 19, 2023

Conversation

DidacSF
Copy link
Contributor

@DidacSF DidacSF commented Jun 15, 2023

Description

This PR splits the AvatarVersion enum into two separate enums with new meanings:

  • DnaEncoding represents how the bytes in the Avatar's DNA are encoded and what each byte represents.
  • LogicGeneration represents which of the available Mint/Forge logics is used

Each LogicGeneration produces avatars with a given DnaEncoding, but a given DnaEncoding version could be produced/manipulated by different LogicGeneration generations.

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

@DidacSF DidacSF requested a review from darkfriend77 June 15, 2023 08:47
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 72.22% and project coverage change: -0.01 ⚠️

Comparison is base (802982e) 70.97% compared to head (ea360ee) 70.96%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #310      +/-   ##
===========================================
- Coverage    70.97%   70.96%   -0.01%     
===========================================
  Files           33       33              
  Lines         3321     3320       -1     
===========================================
- Hits          2357     2356       -1     
  Misses         964      964              
Impacted Files Coverage Δ
pallets/ajuna-awesome-avatars/src/migration/v5.rs 0.00% <0.00%> (ø)
...wesome-avatars/src/types/avatar/versions/v2/mod.rs 57.87% <0.00%> (ø)
pallets/ajuna-awesome-avatars/src/types/config.rs 100.00% <ø> (ø)
pallets/ajuna-awesome-avatars/src/types/season.rs 95.60% <ø> (ø)
...lets/ajuna-awesome-avatars/src/types/avatar/mod.rs 77.77% <66.66%> (ø)
pallets/ajuna-awesome-avatars/src/lib.rs 82.53% <87.50%> (-0.04%) ⬇️
...na-awesome-avatars/src/types/avatar/versions/v1.rs 87.32% <100.00%> (ø)
...atars/src/types/avatar/versions/v2/avatar_utils.rs 84.51% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@darkfriend77 darkfriend77 merged commit 4372002 into develop Jun 19, 2023
@darkfriend77 darkfriend77 deleted the PLAT-803 branch June 19, 2023 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants