Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

[PLAT-756] Add treasury account #233

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

cowboy-bebug
Copy link
Contributor

@cowboy-bebug cowboy-bebug commented Feb 28, 2023

Description

Changes:

  • add a pallet account to hold treasury until claimed by treasurer
  • add checks to prevent setting fees too low (lower than ED)
    • this is extremely unlikely but there for safety

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

@cowboy-bebug cowboy-bebug force-pushed the el/PLAT-756-add-treasury-account branch 2 times, most recently from 3526802 to a3eb448 Compare February 28, 2023 21:44
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 95.00% and project coverage change: +0.15 🎉

Comparison is base (44dbb21) 81.80% compared to head (ab9fc4a) 81.96%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #233      +/-   ##
===========================================
+ Coverage    81.80%   81.96%   +0.15%     
===========================================
  Files           15       15              
  Lines         1072     1087      +15     
===========================================
+ Hits           877      891      +14     
- Misses         195      196       +1     
Impacted Files Coverage Δ
pallets/ajuna-awesome-avatars/src/lib.rs 88.72% <95.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cowboy-bebug cowboy-bebug force-pushed the el/PLAT-756-add-treasury-account branch from a3eb448 to 34cdb00 Compare February 28, 2023 23:03
@cowboy-bebug cowboy-bebug force-pushed the el/PLAT-756-add-treasury-account branch from 34cdb00 to 5badad9 Compare February 28, 2023 23:48
@cowboy-bebug cowboy-bebug force-pushed the el/PLAT-756-add-treasury-account branch from 1960e12 to ab9fc4a Compare March 1, 2023 00:36
@cowboy-bebug cowboy-bebug marked this pull request as ready for review March 1, 2023 01:01
@cowboy-bebug cowboy-bebug merged commit a78335b into develop Mar 1, 2023
@cowboy-bebug cowboy-bebug deleted the el/PLAT-756-add-treasury-account branch March 1, 2023 01:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant