Skip to content

[Fix] #81 - 스토리북 타입 경로 및 아이콘 중복 선언으로 인한 빌드 오류 수정#82

Merged
sebeeeen merged 2 commits into
devfrom
fix/build-ts-errors-storybook-icons
Apr 1, 2026
Merged

[Fix] #81 - 스토리북 타입 경로 및 아이콘 중복 선언으로 인한 빌드 오류 수정#82
sebeeeen merged 2 commits into
devfrom
fix/build-ts-errors-storybook-icons

Conversation

@sebeeeen
Copy link
Copy Markdown
Member

@sebeeeen sebeeeen commented Apr 1, 2026

🔎 What is this PR?

다음 오류를 해결했습니다.

  • 사용하지 않는 React import
  • @storybook/react 타입 경로 불일치
  • FileTextIcon 중복 선언

📝 Changes

  1. avatars.stories.tsx
    • 사용하지 않는 React import 제거
  2. empty-states.stories.tsx
    • Storybook 타입 import를 @storybook/react-vite로 통일
  3. index.tsx
    • 중복 선언된 FileTextIcon 중 두 번째 선언명을 FileTextAltIcon으로 변경
  4. pnpm-lock.yaml
    • lock 메타데이터 갱신 반영(libc 조건 포함)

Summary by CodeRabbit

  • Refactor
    • Updated naming conventions for an icon component to enhance clarity and better reflect its usage in Empty States
    • Enhanced Storybook TypeScript configuration imports for improved build compatibility and optimized development workflows
    • Streamlined component story files by removing unused imports, reducing overall code complexity and improving maintainability

@sebeeeen sebeeeen self-assigned this Apr 1, 2026
@sebeeeen sebeeeen requested a review from kimsman06 April 1, 2026 00:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

Warning

Rate limit exceeded

@sebeeeen has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 1 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 1 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 12e82238-a65c-4451-a0c0-de7b454f5f36

📥 Commits

Reviewing files that changed from the base of the PR and between e32195f and ed83759.

📒 Files selected for processing (2)
  • src/shared/ui/empty_states/empty-states.tsx
  • src/shared/ui/file-uploader/file-uploader.tsx
📝 Walkthrough

Walkthrough

Three files updated to improve consistency: removed unused React import from avatars stories, synchronized Storybook typings import to react-vite variant in empty-states stories, and renamed FileTextIcon export to FileTextAltIcon in the icons module.

Changes

Cohort / File(s) Summary
Storybook Stories Updates
src/shared/ui/avatars/avatars.stories.tsx, src/shared/ui/empty_states/empty-states.stories.tsx
Removed explicit React import from avatars stories; updated Storybook typings import from @storybook/react to @storybook/react-vite in empty-states stories.
Icon Export Rename
src/shared/ui/icons/index.tsx
Renamed exported icon component from FileTextIcon to FileTextAltIcon to reflect alternate style designation for empty states.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • jaeu5325
  • kimsman06

Poem

🐰 Hopping through imports with care,
Renaming icons here and there,
React removed, no longer needed,
Storybook harmonized, as heeded,
Clean and consistent, our work complete!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main changes: fixing Storybook type path issues and icon duplication that caused build errors.
Description check ✅ Passed The description covers the core sections with a clear explanation of issues fixed and changes made, though some optional sections are absent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/build-ts-errors-storybook-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/shared/ui/icons/index.tsx`:
- Around line 482-483: empty-states.tsx is still importing and rendering the
general FileTextIcon instead of the dedicated Empty States variant
FileTextAltIcon; update the import statement in empty-states.tsx to import
FileTextAltIcon (replace FileTextIcon) and update any JSX usage to render
<FileTextAltIcon ...> so the empty state uses the correct default size and
stroke. Ensure any props passed remain compatible with IconProps used by
FileTextAltIcon.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0dbe4d1f-c13f-4a16-88b2-c8c39d5cec2a

📥 Commits

Reviewing files that changed from the base of the PR and between 7f11ff0 and e32195f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • src/shared/ui/avatars/avatars.stories.tsx
  • src/shared/ui/empty_states/empty-states.stories.tsx
  • src/shared/ui/icons/index.tsx
💤 Files with no reviewable changes (1)
  • src/shared/ui/avatars/avatars.stories.tsx

Comment thread src/shared/ui/icons/index.tsx
@sebeeeen sebeeeen merged commit cd90aa8 into dev Apr 1, 2026
1 check passed
@sebeeeen sebeeeen deleted the fix/build-ts-errors-storybook-icons branch April 1, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] dev 브랜치 pnpm build 실패(TypeScript 스토리/아이콘 충돌)

1 participant