-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] #11 - 공통 InputBox 컴포넌트 추가 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
617247a
feat: 공통 inputBox 컴포넌트 구현
jaeu5325 d4c516a
feat: 코드 컨벤션에 맞춰 수정
jaeu5325 1baf502
feat: defaultValue 값 오류 수정
jaeu5325 b65c8f5
feat/pnpm재설치
jaeu5325 46cad0a
feat:coderabbit수정사항 반영
jaeu5325 f5bcdfa
chore: dev 이슈 템플릿 유지
jaeu5325 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,162 @@ | ||||||
| import React from "react"; | ||||||
| import type { Meta, StoryObj } from "@storybook/react-vite"; | ||||||
| import { Input, Textarea, Select } from "./inputBox"; | ||||||
| // 아이콘 임포트 | ||||||
| import { UserIcon, MailIcon, LockIcon, XCircleIcon } from "@/shared/ui/icons"; | ||||||
|
|
||||||
| const meta = { | ||||||
| title: "Shared/UI/InputBox", | ||||||
| component: Input, | ||||||
| parameters: { | ||||||
| layout: "padded", | ||||||
| docs: { | ||||||
| description: { | ||||||
| component: "공통 입력 컴포넌트입니다. Input, Textarea, Select를 포함합니다.", | ||||||
| }, | ||||||
| }, | ||||||
| }, | ||||||
| tags: ["autodocs"], | ||||||
| argTypes: { | ||||||
| // 1. Size | ||||||
| size: { | ||||||
| control: "radio", | ||||||
| options: ["medium", "large"], | ||||||
| description: "입력창 크기 조절", | ||||||
| table: { defaultValue: { summary: "large" } }, | ||||||
| }, | ||||||
| // 2. Boolean States | ||||||
| hasError: { | ||||||
| control: "boolean", | ||||||
| description: "에러 상태 표시 (Red Border)", | ||||||
| }, | ||||||
| isFullWidth: { | ||||||
| control: "boolean", | ||||||
| description: "부모 컨테이너 너비 100% 차지 여부", | ||||||
| table: { defaultValue: { summary: "true" } }, | ||||||
| }, | ||||||
| disabled: { | ||||||
| control: "boolean", | ||||||
| description: "비활성화 상태", | ||||||
| }, | ||||||
| // 3. Icons | ||||||
| leftIcon: { control: false, description: "좌측 아이콘 (ReactNode)" }, | ||||||
| rightIcon: { control: false, description: "우측 아이콘 (ReactNode)" }, | ||||||
| }, | ||||||
| } satisfies Meta<typeof Input>; | ||||||
|
|
||||||
| export default meta; | ||||||
| type Story = StoryObj<typeof meta>; | ||||||
|
|
||||||
| // 기본 텍스트 입력 | ||||||
| export const Default: Story = { | ||||||
| args: { | ||||||
| placeholder: "텍스트를 입력해주세요", | ||||||
| size: "large", | ||||||
| isFullWidth: true, | ||||||
| }, | ||||||
| }; | ||||||
|
|
||||||
| // 아이콘 포함 (User, Mail 아이콘 예시) | ||||||
| export const WithIcons: Story = { | ||||||
| args: { | ||||||
| placeholder: "이메일 입력", | ||||||
| leftIcon: <UserIcon width={20} />, // 아이콘 크기 지정 권장 | ||||||
| rightIcon: <MailIcon width={20} />, | ||||||
| isFullWidth: true, | ||||||
| }, | ||||||
| }; | ||||||
|
|
||||||
| // 비밀번호 입력 (강도 표시 포함) | ||||||
| export const Password: Story = { | ||||||
| args: { | ||||||
| type: "password", | ||||||
| placeholder: "비밀번호를 입력하세요", | ||||||
| leftIcon: <LockIcon width={20} />, | ||||||
| passwordStrength: 2, // 0~3 단계 | ||||||
| isFullWidth: true, | ||||||
| }, | ||||||
| }; | ||||||
|
|
||||||
| // 검색 입력 (Rounded Pill Shape) | ||||||
| export const Search: Story = { | ||||||
| args: { | ||||||
| type: "search", | ||||||
| placeholder: "검색어를 입력하세요...", | ||||||
| size: "medium", | ||||||
| isFullWidth: true, | ||||||
| // onClear가 전달되면 값이 있을 때 X 버튼이 자동으로 노출됨 | ||||||
| onClear: () => alert("Clear Clicked!"), | ||||||
| }, | ||||||
| }; | ||||||
|
Comment on lines
+81
to
+90
|
||||||
|
|
||||||
| // 에러 상태 | ||||||
| export const ErrorState: Story = { | ||||||
| args: { | ||||||
| placeholder: "잘못된 입력", | ||||||
| defaultValue: "유효하지 않은 값", | ||||||
| hasError: true, | ||||||
| isFullWidth: true, | ||||||
| rightIcon: <XCircleIcon width={20} className="text-[color:var(--color-error-500,#EF4444)]" />, | ||||||
| }, | ||||||
| }; | ||||||
|
|
||||||
| export const TextareaField: StoryObj<typeof Textarea> = { | ||||||
| render: (args) => <Textarea {...args} />, | ||||||
| args: { | ||||||
| placeholder: "내용을 자세히 적어주세요.", | ||||||
| maxLength: 200, // 글자수 카운터 표시 | ||||||
| isFullWidth: true, | ||||||
| rows: 4, | ||||||
| }, | ||||||
| argTypes: { | ||||||
| hasError: { control: "boolean" }, | ||||||
| }, | ||||||
| }; | ||||||
|
|
||||||
| export const SelectField: StoryObj<typeof Select> = { | ||||||
| render: (args) => <Select {...args} />, | ||||||
| args: { | ||||||
| placeholder: "옵션을 선택하세요", | ||||||
| isFullWidth: true, | ||||||
| options: [ | ||||||
| { label: "옵션 1", value: "option1" }, | ||||||
| { label: "옵션 2", value: "option2" }, | ||||||
| { label: "옵션 3", value: "option3" }, | ||||||
| ], | ||||||
| }, | ||||||
| }; | ||||||
|
|
||||||
| // all states 모음 | ||||||
| export const States: Story = { | ||||||
| render: () => ( | ||||||
| <div className="flex flex-col gap-5 w-[360px] p-4 border rounded-xl bg-gray-50"> | ||||||
| <h3 className="text-sm font-bold text-gray-500 mb-2">Input States</h3> | ||||||
|
|
||||||
| {/* 1. 기본 */} | ||||||
| <Input placeholder="기본 (Default)" isFullWidth /> | ||||||
|
|
||||||
| {/* 2. 포커스 (autoFocus) */} | ||||||
| <Input placeholder="포커스 (Focus)" autoFocus isFullWidth /> | ||||||
|
|
||||||
| {/* 3. 에러 */} | ||||||
| <Input | ||||||
| placeholder="에러 (Error)" | ||||||
| defaultValue="유효하지 않은 값" | ||||||
| hasError | ||||||
| isFullWidth | ||||||
| rightIcon={<XCircleIcon className="text-red-500" width={20} />} | ||||||
|
||||||
| rightIcon={<XCircleIcon className="text-red-500" width={20} />} | |
| rightIcon={<XCircleIcon className="text-[color:var(--color-error-500,#EF4444)]" width={20} />} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear button won't be visible without a
valueprop.The
onClearcallback is provided but the clear button only renders whenprops.value && onClearis truthy (per component logic at line 188 in inputBox.tsx). Without avalue, users won't see the clear functionality in this story.🔧 Proposed fix to demonstrate clear functionality
export const Search: Story = { args: { type: "search", placeholder: "검색어를 입력하세요...", size: "medium", isFullWidth: true, + value: "검색어 예시", // onClear가 전달되면 값이 있을 때 X 버튼이 자동으로 노출됨 onClear: () => alert("Clear Clicked!"), }, };📝 Committable suggestion
🤖 Prompt for AI Agents