Skip to content

[Feat] #110 - navigation 로고를 통합 텍스트 SVG로 교체#110

Merged
kimsman06 merged 1 commit into
devfrom
feat/navigation-logo
May 21, 2026
Merged

[Feat] #110 - navigation 로고를 통합 텍스트 SVG로 교체#110
kimsman06 merged 1 commit into
devfrom
feat/navigation-logo

Conversation

@kimsman06
Copy link
Copy Markdown
Collaborator

@kimsman06 kimsman06 commented May 20, 2026

🔎 What is this PR?


📝 Changes

  • src/shared/ui/navigation/navigation.tsx<img src>/assets/ajou-logo.svg/assets/aim-ajou-logo_text.svg 로 교체
  • 통합 로고에 텍스트가 포함되어 있으므로 옆에 있던 "AIM AJOU" 텍스트 <span> 제거
  • 통합 로고 가독성에 맞춰 컨테이너 크기 h-8 w-8h-12 w-12 로 확대, 불필요한 gap-[6px] 제거
  • public/assets/aim-ajou-logo_text.svg, public/assets/aim-ajou-logo.svg 자산 추가

📸 Screenshots (선택)


📚 Background / Context (선택)

  • figma design에 정의된 통합 로고 시안을 navigation에 반영하기 위한 작업입니다.
  • 아이콘 + 별도 텍스트 span 구조를 단일 SVG 자산으로 일원화하여 시각적 정합성과 유지보수성을 확보합니다.

✔ Checklist

  • 코드는 로컬에서 정상적으로 빌드됩니다 (pnpm build)
  • ESLint / Prettier 통과 (pnpm lint)
  • 네이밍/레이어 컨벤션 준수 (camelCase/PascalCase, is·has 불린 접두사, alias 계층 규칙)
  • 관련 문서/주석 반영 (필요 시)
  • 주요 로직에 테스트 또는 검증 완료

🙏 Request

  • figma design 시안과 표시 결과 비교 부탁드립니다. 로고 크기(h-12 w-12)나 컨테이너 패딩 조정이 필요하면 코멘트 남겨주세요.

Summary by CodeRabbit

  • Style
    • Updated the navigation header logo with a new visual design for improved appearance.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 76083eb9-6be3-4ee4-b96b-23900b6c015a

📥 Commits

Reviewing files that changed from the base of the PR and between eb21c5f and 8269074.

⛔ Files ignored due to path filters (2)
  • public/assets/aim-ajou-logo.svg is excluded by !**/*.svg
  • public/assets/aim-ajou-logo_text.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • src/shared/ui/navigation/navigation.tsx

📝 Walkthrough

Walkthrough

Navigation component header logo is updated from separate Ajou icon and text span to a single combined SVG image, with container dimensions adjusted accordingly. No API or behavior changes.

Changes

Navigation Logo Update

Layer / File(s) Summary
Navigation logo markup update
src/shared/ui/navigation/navigation.tsx
Logo section replaces previous Ajou icon + "AIM AJOU" text markup with single aim-ajou-logo_text.svg in h-12 w-12 container.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • sebeeeen

Poem

🐰 A logo once scattered now whole and bright,
From icon and text to one SVG file,
The navigation wears its new design with delight,
United and crisp in each pixel's style! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: replacing the navigation logo with an integrated SVG text image, directly referencing issue #109.
Description check ✅ Passed The PR description comprehensively follows the template with all key sections completed: purpose, changes, background/context, and checklist items properly documented.
Linked Issues check ✅ Passed All requirements from issue #109 are met: SVG source replacement, text span removal, container resizing, and asset addition are properly implemented.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the navigation logo replacement objective; no unrelated modifications detected in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/navigation-logo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sebeeeen sebeeeen self-requested a review May 20, 2026 12:41
@kimsman06 kimsman06 merged commit f4e96cc into dev May 21, 2026
1 check passed
@kimsman06 kimsman06 changed the title [Feat] #109 - navigation 로고를 통합 텍스트 SVG로 교체 [Feat] #110 - navigation 로고를 통합 텍스트 SVG로 교체 May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] navigation 로고 교체

2 participants