Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test #1

Closed
wants to merge 4 commits into from
Closed

test #1

wants to merge 4 commits into from

Commits on Nov 17, 2016

  1. Allow plain table to store index on file with bloom filter disabled 

    Summary:
Currently plain table bloom filter is required if storing metadata on file. Remove the constraint.
Closes facebook#1525

Differential Revision: D4190977

Pulled By: siying

fbshipit-source-id: be60442
    @siying
    siying authored and Facebook Github Bot committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    a4eb738 View commit details
    Browse the repository at this point in the history

  2. Fix heap use after free ASAN/Valgrind 

    Summary:
Dont use c_str() of temp std::string in RocksLuaCompactionFilter::Name()
Closes facebook#1535

Differential Revision: D4199094

Pulled By: IslamAbdelRahman

fbshipit-source-id: e56ce62
    @IslamAbdelRahman
    IslamAbdelRahman authored and Facebook Github Bot committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    f39452e View commit details
    Browse the repository at this point in the history

  3. refactor TableCache Get/NewIterator for single exit points 

    Summary:
these functions were too complicated to change with exit points everywhere, so refactored them.

btw, please review urgently, this is a prereq to fix the 5.0 perf regression
Closes facebook#1534

Differential Revision: D4198972

Pulled By: ajkr

fbshipit-source-id: 04ebfb7
    @ajkr
    ajkr authored and Facebook Github Bot committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    635a7bd View commit details
    Browse the repository at this point in the history

  4. Eliminate redundant cache lookup with range deletion

    @ajkr
    ajkr committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    f2697bf View commit details
    Browse the repository at this point in the history