Fixed 2 issues with relationship links when using a camel case model #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r specifications Moved the data inside the interrupt for populate so you can modify it in interupts Allow use of filter parameter for the where clause and split id string by ,
started simplifying actions to be more readable using native async/await rather than the async library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the relationship links would be kebab case for instance 'localhost:1337/media-outlets/5/publishers', which sails will not pick up by default. I have adjusted it so it will return 'localhost:1337/mediaOutlets/5/publishers'.
I also found an issue where the type wasn't registered in JSONAPISerializer as sails.model.associations.model was all lowercase instead of camel case. Therefore, the kebabCase call wasn't functioning as expected. There is now a modelMap which will properly define the type name in kebabCase.