Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix popups being covered by page scrollbar #5763

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

nightwing
Copy link
Member

Fixes the issue where autocomplete popup and doc tooltip could be covered by page scrollbar, or could extend outside of viewport.

@nightwing nightwing force-pushed the fix-popup-positioning branch 3 times, most recently from 1ef1ed7 to e55d8bd Compare March 5, 2025 09:43
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.15%. Comparing base (cd78a94) to head (f142dbf).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5763      +/-   ##
==========================================
+ Coverage   87.10%   87.15%   +0.04%     
==========================================
  Files         602      602              
  Lines       44092    44157      +65     
  Branches     7234     7240       +6     
==========================================
+ Hits        38407    38484      +77     
+ Misses       5685     5673      -12     
Flag Coverage Δ
unittests 87.15% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nightwing nightwing force-pushed the fix-popup-positioning branch from e55d8bd to f5003fb Compare March 12, 2025 15:53
@nightwing nightwing force-pushed the fix-popup-positioning branch from f5003fb to f142dbf Compare March 14, 2025 12:36
@nightwing nightwing merged commit 2516181 into master Mar 19, 2025
3 checks passed
@nightwing nightwing deleted the fix-popup-positioning branch March 19, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants