Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow button for long lines with one token #4818

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Fix overflow button for long lines with one token #4818

merged 1 commit into from
Jun 3, 2022

Conversation

Exaphis
Copy link
Contributor

@Exaphis Exaphis commented Jun 2, 2022

Issue #, if available: #4817

Description of changes: Check if MAX_LINE_LENGTH is reached for the first token as well as the others.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

lib/ace/layer/text.js Outdated Show resolved Hide resolved
lib/ace/layer/text.js Outdated Show resolved Hide resolved
@Exaphis
Copy link
Contributor Author

Exaphis commented Jun 3, 2022

Saw the build failed due to renderIndentGuide being passed a token instead of value. Also noticed that value should be updated with the result of renderIndentGuide, so I refactored it to use similar logic to renderWrappedLine.

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #4818 (4cae849) into master (5c35ca8) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #4818      +/-   ##
==========================================
- Coverage   71.11%   71.11%   -0.01%     
==========================================
  Files         554      554              
  Lines       55716    55714       -2     
  Branches    10420    10420              
==========================================
- Hits        39624    39620       -4     
- Misses      16092    16094       +2     
Flag Coverage Δ
unittests 71.11% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/layer/text.js 90.81% <85.71%> (-0.30%) ⬇️
lib/ace/editor.js 79.66% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c35ca8...4cae849. Read the comment docs.

@andrewnester andrewnester merged commit 3f93451 into ajaxorg:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants