Improve tooltips #2189
Merged
Improve tooltips #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow tooltips in div element (currently tooltips only allow items in pre element which is tricky to format). Also fix wrapping, remove gradient fill, and introduce a maximum width of 500px by default.
|
Preview of the tooltip, some parts of the screenshot have been obfuscated. Capping the tooltip size at 500px is somewhat arbitary, and perhaps there is a better solution, but, subjectively speaking I think it is a good value, and without it, larger blocks of context sensitive help is simply unreadable on very wide monitors. Any constructive criticism welcome. |
| @@ -352,12 +352,13 @@ var Autocomplete = function() { | |||
|
|
|||
| this.showDocTooltip = function(item) { | |||
| if (!this.tooltipNode) { | |||
| this.tooltipNode = dom.createElement("pre"); | |||
| this.tooltipNode = item.docHTML ? dom.createElement("div") : dom.createElement("pre"); | |||
There was a problem hiding this comment.
I think it would be ok to always use div
There was a problem hiding this comment.
Always use div is fine by me :-)
Removed style changes (no style changes are part of the PR). Only change now should be that we create a <div/> element instead of a <pre/> element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tooltips in div element (currently tooltips only allow items in pre element which is tricky to format). Also fix wrapping, remove gradient fill, and introduce a maximum width of 500px by default.