Update REST Catalog impl for smoke tests and remove obsolete override for test#1
Conversation
|
|
||
| @Test | ||
| @Override | ||
| public void testDropTableWithMissingDataFile() | ||
| { | ||
| assertThatThrownBy(super::testDropTableWithMissingDataFile) | ||
| .hasMessageContaining("Table location should not exist"); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
This test was failing expectedly after the upgrade because we made the change to remove Puffin files as part of https://github.com/apache/iceberg/pull/9305/files . We used to expect this test to fail in this override because Puffin files would linger after the "DROP" and we have an assertion that validates that all files are removed so the test would fail. Now, this override is no longer needed, we expect the base testDropTableWithMissingDataFile to pass. So we can just remove the test override and rely on the base.
| static class TestingJdbcCatalog | ||
| extends JdbcCatalog implements ViewCatalog |
There was a problem hiding this comment.
This is needed since the upgraded 1.5 RestSessionCatalog will check if a view exists when performing a replace. This effectively means the underlying catalog being used must implement ViewCatalog otherwise the loadView call will fail since the response cannot be parsed.
To fix this, I'm implementing a TestingJdbcCatalog which implements ViewCatalog. We'll need this anyways in the REST View Catalog implementation PR. trinodb#19818
2 participants
… for test
Description
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: