Skip to content

KIP-405: 2023-08-21#38

Closed
jeqo wants to merge 6 commits into
ak/trunkfrom
kips/KIP-405/2023-08-21
Closed

KIP-405: 2023-08-21#38
jeqo wants to merge 6 commits into
ak/trunkfrom
kips/KIP-405/2023-08-21

Conversation

@jeqo

@jeqo jeqo commented Aug 21, 2023

Copy link
Copy Markdown

NOTE: not meant to be merged, but to create a working snapshot of the current work ongoing on KIP-405. We expect these fixes to land on the upstream trunk eventually.

Branch pulling latest changes related to Kafka Tiered Storage, KIP-405.

Includes the following PRs:

And fixes/workarounds for:

Squashed changes are cherry-picked and small fixes are included on top of the upstream trunk.

A docker image can be built with the following tag: aivenoy/kafka:kips_KIP-405_2023-08-21

jeqo and others added 6 commits August 21, 2023 11:39
…y based on time and size

Fixed setting right start offset while searching for offsets based on timestamp, covering with and without tiered storage scenarios

Addressed review comments

Addressed review comments
 - Added segment epoch validation with leader epochs for find offset timestamp apis

Addressed review comments

Addressed review comments

Added a UT for incrementing log-start-offset with remote storage enabled

Minor cleanup in the test to cover more scenarios.

Addressed review comments

Addressed review comments
 - Added filtering to remove epochs with no records while deleting remote segments.

Addressed review comments

Addressed reveiw comments

Addressed review comments

Pulled the trunk changes and fixed the conflicts.

Addressed review comments

Addressed reveiw comments.
Minor cleanup.

A few more cases added to the test

Added more checks and respective tests.

Addressed review comments
 - Integrated with the remoteLogSize API

Addressed review comments

Addressed reveiw comments
Updating _localLogStartOffset appropriately covering both the scenarios.

Addressed a minor review comments

Addressed review comments

Addressed review comments

Addressed review comments

Delete only when the segment is copied to tiered storage

Addressed minor reveiw comments

Fixed a few log message typos.

Added remote log segments retention functionality based on time and size
 - RLMTask runs retention cleanup activity in each execution for the targeted topic partition. It checks for total size, retention time and deletes the eligible segments from remote storage. It also updates the log-start-offset in UnifiedLog.
…ter assigning partitions

Address review comments

Address review comments

Address review comments

KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions
As many metadata updates are produced concurrently, producer/consumer offset checking seems to get into race conditions, and the whole future times out.

To fix this, futures are chained sequentially to run each update individually.

We should research further, but in the meantime, treating these as sequential seems safer.

[KAFKA-15130]: https://issues.apache.org/jira/browse/KAFKA-15130
@jeqo jeqo mentioned this pull request Aug 21, 2023
jeqo added a commit to Aiven-Open/tiered-storage-for-apache-kafka that referenced this pull request Aug 23, 2023
Image building from PRs like: aiven/kafka#38
jeqo added a commit to Aiven-Open/tiered-storage-for-apache-kafka that referenced this pull request Aug 23, 2023
Image building from PRs like: aiven/kafka#38
jeqo added a commit to Aiven-Open/tiered-storage-for-apache-kafka that referenced this pull request Aug 23, 2023
Image building from PRs like: aiven/kafka#38
jeqo added a commit to Aiven-Open/tiered-storage-for-apache-kafka that referenced this pull request Aug 23, 2023
Image building from PRs like: aiven/kafka#38
jeqo added a commit to Aiven-Open/tiered-storage-for-apache-kafka that referenced this pull request Aug 23, 2023
Image building from PRs like: aiven/kafka#38
jeqo added a commit to Aiven-Open/tiered-storage-for-apache-kafka that referenced this pull request Aug 28, 2023
Image building from PRs like: aiven/kafka#38
jeqo added a commit to Aiven-Open/tiered-storage-for-apache-kafka that referenced this pull request Aug 28, 2023
Image building from PRs like: aiven/kafka#38
jeqo added a commit to Aiven-Open/tiered-storage-for-apache-kafka that referenced this pull request Aug 28, 2023
Image building from PRs like: aiven/kafka#38
jeqo added a commit to Aiven-Open/tiered-storage-for-apache-kafka that referenced this pull request Sep 1, 2023
Image building from PRs like: aiven/kafka#38
@jeqo jeqo closed this Sep 14, 2023
davide-armand pushed a commit that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants