feat: modify retryablehttp retry setting values #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rriski
force-pushed
the
rriski-increase-retry-settings
branch
from
5395533
to
3c7d12e
Compare
rriski
changed the title
rriski
force-pushed
the
rriski-increase-retry-settings
branch
from
3c7d12e
to
cb851a1
Compare
* RetryWaitMin: increase to 2 seconds (library default is 1 second) * RetryWaitMax: decrease to 10 seconds (library default is 30 seconds) * RetryMax: increase to 6 (library default is 4)
rriski
force-pushed
the
rriski-increase-retry-settings
branch
from
cb851a1
to
dad1fab
Compare
ssuomi-aiven
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Modify retryablehttp retry setting values:
Explanation of chosen values:
Retry Settings Explanation
Maximum Wait Time if All Attempts Fail
Why this way
Attempt to fix flaky aiven-operator tests: https://github.com/aiven/aiven-operator/actions/runs/10938155919/job/30365698081. Kafka connect schema version API didn't respond with 200 in time with the old retry settings.