Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deploy option to generate .cmd file for Windows and .sh files for macOS / Linux #692

Merged
merged 5 commits into from
Jan 20, 2020

Conversation

kensoh
Copy link
Member

@kensoh kensoh commented Jan 19, 2020

@siowyisheng for your review and testing on Windows, checked for macOS.

Copy link
Contributor

@siowyisheng siowyisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and tested

@siowyisheng siowyisheng merged commit 5a07c4c into develop Jan 20, 2020
@kensoh kensoh deleted the deploy_option branch January 20, 2020 05:01
@kensoh
Copy link
Member Author

kensoh commented Jan 26, 2020

@siowyisheng raised #700 for your review and testing. Works on mac. Thought that adding output message is better rather than returning to prompt silently.

siowyisheng pushed a commit that referenced this pull request Feb 3, 2020
* deploy option output message on windows

* deploy option output message for macos/linux
siowyisheng added a commit that referenced this pull request Mar 10, 2020
… macOS / Linux (#692)

* deploy workflow option for macOS & Linux

* add deploy option for Windows

* deploy option for Windows

* deploy option for Windows

* fix: allows double click to work on macos

Co-authored-by: Yi Sheng <[email protected]>
siowyisheng pushed a commit that referenced this pull request Mar 10, 2020
* deploy option output message on windows

* deploy option output message for macos/linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants