Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation not working for tagui step calling subflow file - fixed with PR #779 #778

Closed
Robertsson opened this issue Apr 6, 2020 · 5 comments
Labels

Comments

@Robertsson
Copy link

Robertsson commented Apr 6, 2020

mainflow.tag

popup someurl
   tagui subflow.tag

Whatever is in the subflow.tag wont be executed on the popup.
I'm guessing all the commands in the subflow.tag ignores the new indentation so they get executed on the main tab.

@kensoh
Copy link
Member

kensoh commented Apr 6, 2020

You are right, thanks! I think the current implementation does not automatically indent everything in subflow.tag. Fyi @siowyisheng on a use case which is not working with the v6 indentation implementation. Will have a look to see what code change needed to make this work.

@kensoh kensoh added the bug label Apr 6, 2020
@kensoh kensoh changed the title popup and tagui-flows Indentation not working with tagui step for subflow file - to fix Apr 6, 2020
@kensoh kensoh changed the title Indentation not working with tagui step for subflow file - to fix Indentation not working for tagui step calling subflow file - to fix Apr 6, 2020
@kensoh
Copy link
Member

kensoh commented Apr 7, 2020

Hi @siowyisheng made a PR #779 that passes following tests. For your review and verification -

a.tag

for n from 1 to 3
    tagui b.tag

b.tag

echo 1
echo 2
echo 3

c.tag

http://tebel.org
click Automation projects
popup automation_projects
    tagui d.tag

d.tag

echo line 1
show file-automation_projects-LC2
echo line 2
show file-automation_projects-LC2

e.tag

echo 1
tagui f.tag
echo 2

f.tag

echo 1.5
echo 1.7

@kensoh kensoh changed the title Indentation not working for tagui step calling subflow file - to fix Indentation not working for tagui step calling subflow file - PR done Apr 10, 2020
siowyisheng added a commit that referenced this issue Apr 20, 2020
#778 - fix indentation for tagui step to call subflow
@kensoh
Copy link
Member

kensoh commented Apr 21, 2020

Closing issue, the change above will be available in the next packaged release, or now by directly downloading from https://github.com/kelaberetiv/TagUI/archive/master.zip now to overwrite user current installation.

@kensoh kensoh closed this as completed Apr 21, 2020
@kensoh kensoh reopened this Dec 4, 2020
@kensoh kensoh changed the title Indentation not working for tagui step calling subflow file - PR done Indentation not working for tagui step calling subflow file - fixed with PR #779 Dec 4, 2020
@kensoh
Copy link
Member

kensoh commented Dec 4, 2020

Reopening this issue as the fix is not yet in the packaged zip. Users can download the latest copy of the code from here and unzip to overwrite their existing installations (please drag the folders under tagui\src to overwrite existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip

In the next release, this will become part of the packaged zip files.

@kensoh
Copy link
Member

kensoh commented Dec 19, 2020

Closing issue since the latest packaged release TagUI v6.14 is out.

Release notes - https://github.com/kelaberetiv/TagUI/releases/tag/v6.14.0
To download v6.14 - https://tagui.readthedocs.io/en/latest/setup.html
Documentation - https://tagui.readthedocs.io/en/latest/index.html

@kensoh kensoh closed this as completed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants