Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fake ESMを純粋なESMに置き換え、commonjsとesmodule用にエクスポートするように #310

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

ikasoba
Copy link
Collaborator

@ikasoba ikasoba commented Aug 30, 2023

What

  • fake ESMとしてビルドされていたものを純粋なESMとしてビルドされるようソースコードを一部置換
  • esmodule と commonjs の双方から利用できるように

Why

#308 を解決するため

Additional info (optional)

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 97.43% and project coverage change: +0.04% 🎉

Comparison is base (b6ca5fc) 87.79% compared to head (43cd9bf) 87.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   87.79%   87.84%   +0.04%     
==========================================
  Files          19       20       +1     
  Lines        3203     3224      +21     
  Branches      524      526       +2     
==========================================
+ Hits         2812     2832      +20     
- Misses        380      381       +1     
  Partials       11       11              
Files Changed Coverage Δ
src/@types/parser.d.ts 0.00% <0.00%> (ø)
src/utils/mini-autobind.ts 95.23% <95.23%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/interpreter/index.ts 91.15% <100.00%> (ø)
src/interpreter/lib/std.ts 74.69% <100.00%> (ø)
src/interpreter/primitive-props.ts 97.63% <100.00%> (ø)
src/interpreter/scope.ts 92.10% <100.00%> (ø)
src/interpreter/util.ts 68.71% <100.00%> (ø)
src/interpreter/value.ts 100.00% <100.00%> (ø)
src/parser/index.ts 82.95% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 01f41a4 into aiscript-dev:master Aug 30, 2023
4 checks passed
@syuilo
Copy link
Collaborator

syuilo commented Aug 30, 2023

🙏🙏🙏

@FineArchs FineArchs mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants