[#52] Add rules for Minikube #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljupcovangelski
commented
Jun 28, 2022
minikube/minikube.bzl
Outdated
| ) | ||
|
|
||
| def _minikube_start_impl(ctx): | ||
| script = "{} -p airy-core start --driver=docker --cpus=4 --memory=7168 --container-runtime=containerd --ports=80:80 --extra-config=apiserver.service-nodeport-range=1-65535".format(ctx.executable._minikube_binary.path) |
There was a problem hiding this comment.
Probably all of these attributes should be submitted as attributes, particularly the name of the profile.
chrismatix
reviewed
Jul 5, 2022
chrismatix
reviewed
Jul 5, 2022
README.md
Outdated
| **Parameters:** | ||
|
|
||
| - `name` Unique name of the rule. | ||
| - `_helm_binary` (optional) Location of the Minikube binary to be used (Defaults to the binary downloaded with the repository rule). |
There was a problem hiding this comment.
Suggested change
| - `_helm_binary` (optional) Location of the Minikube binary to be used (Defaults to the binary downloaded with the repository rule). | |
| - `_helm_binary` (optional) Location of the Minikube binary to be used (Defaults to the binary downloaded with the repository rule). |
chrismatix
reviewed
Jul 5, 2022
ljupcovangelski
force-pushed
the
feature/52-minikube-rules
branch
from
731d785
to
c421d1c
Compare
chrismatix
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.