Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #132

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Dark theme #132

wants to merge 6 commits into from

Conversation

anewuser
Copy link

@anewuser anewuser commented Jun 20, 2024

The configuration page is too bright. I've added some dark colors for people who prefer them.

To test this style: Change website appearance settings in Firefox.

@airtower-luna airtower-luna added the enhancement New feature or request label Jun 23, 2024
Copy link
Owner

@airtower-luna airtower-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a dark theme for people who prefer that is very welcome, thank you!

Is there are particular reason you didn't make table and input fields use light-on-dark text?

style.css Outdated Show resolved Hide resolved
style.css Outdated Show resolved Hide resolved
style.css Outdated Show resolved Hide resolved
@anewuser
Copy link
Author

anewuser commented Jun 25, 2024

Thank you for the comments. I hadn't styled it properly before because I wasn't sure if you were interested in adding this. Please take another look at it.

Screenshotdark theme

Copy link
Owner

@airtower-luna airtower-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style looks good to me now, just some space issues in the CSS left: one double space, and a bunch of lines with space at EOL (unfortunately the GitHub web diff doesn't highlight that, a local git diff should, and any editor that supports Editorconfig should prevent it). 😺

style.css Outdated Show resolved Hide resolved
@Gitoffthelawn
Copy link
Contributor

Just a quick note. I have a custom CSS overlay that I wrote that I apply to the extension's settings UI. It does a dark theme as well as makes some important (IMO) UX improvements.

I'm super busy for another week, but if you ping me in about 4-5 days, I can share the code with you if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants