[TT-40] Expand output path with tilde #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfportal
approved these changes
Jul 24, 2019
fwouts
approved these changes
Jul 24, 2019
| @@ -255,7 +255,8 @@ OPTIONS | |||
| -h, --help show CLI help | |||
| -p, --port=port (required) [default: 3010] Port on which to run the mock server | |||
| --pathPrefix=pathPrefix Prefix to prepend to each endpoint path | |||
| --proxyBaseUrl=proxyBaseUrl If set, the server would act as a proxy and fetch data from the given remote server | |||
|
|
|||
| --proxyBaseUrl=proxyBaseUrl If set, the server will act as a proxy and fetch data from the given remote server | |||
| @@ -0,0 +1,11 @@ | |||
| import os from "os"; | |||
|
|
|||
| export default function expandPathWithTilde(path: string) { | |||
There was a problem hiding this comment.
Consider using a named export to follow conventions in the Spot codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node doesn't expand
~to the current user's home directory - see nodejs/node#684.Looks like this has to be implemented manually if we really want to leverage this feature, hence the following changes.