-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look into android latest (7.1) failure #3
Comments
Haven't looked too deep, but my guess is this is related to the following caveat: |
Upstream issue: airtap/browsers#3
OK, so it works if we set On the other hand, more specific names like 'Samsung Galaxy S8 GoogleAPI Emulator' are returned. We could choose one of the available names arbitrarily, or hardcode 'Android GoogleAPI Emulator' somewhere (not ideal). Thoughts? |
In which way is this broken? |
Any test that uses android 7 fails:
The exception thrown in webdriver itself when trying to generate the error message is a separate issue. |
Some digging (and annoying multiple property translations) just to get some more information on what it looks like now. When asking the sauce labs api we get the following meta data: {
"short_version": "7.1",
"long_name": "Samsung Galaxy Tab A 10 GoogleAPI Emulator",
"api_name": "android",
"long_version": "7.1.",
"device": "GalaxyTabA10GoogleAPI",
"latest_stable_version": "",
"automation_backend": "webdriver",
"os": "Linux"
} Current functionality is to pick Which then gets translated to https://github.com/airtap/airtap/blob/master/lib/airtap.js#L55 Which then gets translated to https://github.com/airtap/airtap/blob/master/lib/sauce-browser.js#L59 |
I'm thinking the ideal solution is to be able to use the first info struct we get from their api and just pass that back to sauce labs when requesting a test and get rid of all these translations in the first place. But that would require interaction with sauce labs and get their support to improve on this. |
Some more information. When using Please correct me if I'm wrong. Also, the status on the |
If we can't get that ^ to work it seems to me that the problem lies at Sauce Labs. |
Oh apparently |
admc/wd#522 was submitted to fix the |
I just noticed the browsers:
- name: iphone
version: latest |
If I manually update
What does this mean?
Any ideas? |
I had issues with the same browser yesterday: airtap/airtap#152 (comment). But after a few retries it did succeed. |
I just merged airtap/airtap#165 which upgrades This still doesn't fix Android 7. Still getting:
|
@vweevers Retrying does not help for the iPhone error I'm getting. It seems similar to the Android 7 issue (i.e. it's a browser configuration issue):
|
Seeing the same thing now on memdown. To verify that appium is the problem, maybe we can try |
Tried
|
Another potential problem is that {
"short_version": "11.3",
"long_name": "iPhone 5s Simulator",
"api_name": "iphone",
"long_version": "11.3.",
"device": "iPhone 5s",
"latest_stable_version": "",
"automation_backend": "webdriver",
"os": "Mac 10.13"
}, {
"short_version": "11.3",
"long_name": "iPhone X Simulator",
"api_name": "iphone",
"long_version": "11.3.",
"device": "iPhone X",
"latest_stable_version": "",
"automation_backend": "webdriver",
"os": "Mac 10.13"
} This can cause
|
@vweevers Lets dedup this in |
Also, I think we should do something about the translations I mentioned above. |
Long-term, definitely. But for lack of unit tests, we should be careful to change too much at once. |
@feross in the mean time you can downgrade to iphone 11.2: - name: iphone
version: 11.2
platform: Mac 10.12 |
(beware though, because of the dedup issue, this will start 12 identical jobs!) |
Scratch that. iphone 11.2 and ipad are now also failing. |
I think this is by design, if you don't specify - name: iphone
version: 11.2
platform: Mac 10.12 asks to test all browsers whose name matches iphone, have version 11.2 and platform Mac 10.12, not just one. |
@lpinca you're not wrong. For the time being though, we have to deduplicate (in airtap) because airtap currently ignores the |
@vweevers It's basically this key that should be unique, right? Damnit! Sometimes I can't get permalinks to work. |
No, nevermind. |
Well, actually, yes 😆 These property translations are painful to me. In other words we should dedupe on They translate into:
But isn't the the final |
Those don't work cross-repo, sadly. Let's continue discussion at airtap/airtap#168? |
Makes sense now! |
I'm still getting something similar:
Is this the same issue? |
@jhiesey if you're on latest |
Yup I'm using v0.1.0 I might take a look into this soonish if nobody else does. |
Finally figured this out for real! For Android and iOS, we and Sauce Labs use the appium automation backend. However, |
Plus, we should be sending it to Sauce Labs like so: caps['deviceName'] = 'Android GoogleAPI Emulator';
caps['browserName'] = 'Chrome';
caps['platformVersion'] = '7.1';
caps['platformName'] = 'Android'; Rather than what we do now (which Sauce Labs in fact translates into the above): caps['deviceName'] = 'Android GoogleAPI Emulator';
caps['browserName'] = 'android';
caps['version'] = '7.1';
caps['platform'] = 'Linux'; |
Wrote https://github.com/airtap/sauce-browsers to handle this (will replace |
No description provided.
The text was updated successfully, but these errors were encountered: