Conversation
The BlocSelector reported isLoading=false whenever the dashboard bloc was already DashboardLoaded, ignoring the widget's own async init (cache read, location fetch, distance filtering). Since NearbyView only mounts once the dashboard is loaded, the first frame skipped the skeleton and rendered the 'No stations nearby' empty state, which was replaced by cards a few frames later once the cache read completed. - Compute isLoading in a BlocBuilder from the live local fields; a BlocSelector only re-runs its selector on bloc emissions, so local setState updates were invisible to it (and the selector returned a fresh Map each time, defeating memoization anyway). - Keep _isLoading true until _updateNearbyLocations actually filters measurements (or determines there are none), instead of clearing it as soon as a position is obtained. - Reset _isLoading/_errorMessage on retry so the skeleton shows again.
DashboardLoading was the only branch that ignored _isLoading, so a generic location error that occurred before a dashboard reload would hide behind the skeleton instead of rendering the error/empty state. Align it with the other branches.
…a reliability
- Correct the filter card wordmark ("Africa Clean Air Forum") and event
date range (13TH-16TH JULY)
- Stop echoing the submitter's display name/email in the "sent to wall"
toast — the wall submission still carries it, just not shown in-app
- Add a bordered status-banner palette (AppAlertColors) and inline
loading state to the share sheet's message banner
- Harden the camera screen against overlapping sessions, hung native
camera calls, and lock-screen interruptions mid-capture
… to remove token dependency
… FacesOfCleanAirPage
Edited sha references in deploy preview
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ate-flash Fix Near You tab flashing empty state before cards load
… remove delete/hide submission logic
- Guard _openCamera against re-entrancy: retry-on-failure and lifecycle-resume could both call it close together, opening two CameraController sessions at once and tripping the Camera2 HAL - Don't reopen the camera on resume when no cameras were discovered (permission denied / cameraless device) — indexed into an empty list - Check _isSendingToWall before rasterizing the filter card, not just before the network call, so a fast consent+photo-change race doesn't do a wasted capture pass - Wrap the inactive-branch controller.dispose() in unawaited(), matching the rest of the file
…selfie-filter-mobile-fixes Polish Clean Air Forum selfie filter: branding copy, loader UX, camer…
update faces of clean air page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.